Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(editor-setup): Mention built-in in LSP mode #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcs090218
Copy link
Member

No description provided.

@@ -1,4 +1,4 @@
## We ❤ Contributions!
## We ❤ Contributions!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this "heart" should be changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heart is changed because there is an unrecognized character on Windows.

I've tried to revert it, but nothing has changed. 🤔 (For some reason, it remains the blue heart instead of the original red heart.)

@@ -110,6 +110,11 @@ A simple Emacs Lisp configuration that adds nixd to LSP Mode in the mean time is
:server-id 'nixd)))
```

> [!NOTE]
>
> The client is built-in to lsp-mode after `8.0.0`; you don't need this if you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client

Which client?

you don't need this if you

Then what should users do (e.g. modifying the config) in this case? Could you provide a detailed code snippet to elaborate?

Copy link
Member Author

@jcs090218 jcs090218 Sep 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which client?

The lsp-mode is the client implementation. 🤔

Then what should users do (e.g. modifying the config) in this case? Could you provide a detailed code snippet to elaborate?

Users should still use the snippet that has already been provided.


The note simply informs users that they do not need to customize or add a snippet to their configuration after 8.0.0 since it's built-in; otherwise, it is redundant.

@inclyc
Copy link
Member

inclyc commented Sep 21, 2024

Hi @jcs090218, why this PR is closed? I think it is a good direction to improve the documentation.

@jcs090218 jcs090218 restored the docs/lsp-mode branch September 21, 2024 03:31
@jcs090218
Copy link
Member Author

Hi @jcs090218, why this PR is closed? I think it is a good direction to improve the documentation.

My goal was to inform the repo owner about the changes. I think I have fulfilled my intention; therefore, I closed it.

I'll reopen it.

@jcs090218 jcs090218 reopened this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants